Enable bitcode + chroma threshold #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll keep this PR pending as I'm working on bringing back GVR. |
|
I don't believe this will cause any problems with GVR. The only reason i included: "Note: Had to remove GVRSDK from Virokit.podspec" is because I noticed that in the latest ViroKit.podspec in /viro it is missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Recompiles the ios/Libraries binaries with bitcode enabled for arm64, armv7, x86_64
-Enables bitcode for "Release" scheme (however bitcode only gets enabled during archive builds apparently)
-Sets the chroma_threshold_sensitivity default to a more sensible 0.1 that filters out a smaller color space surrounding the target chroma key filter.
Note: Had to remove GVRSDK from Virokit.podspec