Organized job memory handling #137

alongd · 2019-06-15T02:08:43Z

Organized the memory used for each ESS
Added an optional memory attribute to the servers dictionary to limit the requested memory if needed

codecov · 2019-06-15T04:02:09Z

Codecov Report

Merging #137 into master will increase coverage by 0.04%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   41.59%   41.63%   +0.04%     
==========================================
  Files          23       23              
  Lines        5813     5824      +11     
  Branches     1536     1540       +4     
==========================================
+ Hits         2418     2425       +7     
+ Misses       3026     3025       -1     
- Partials      369      374       +5

Impacted Files	Coverage Δ
arc/job/submit.py	`100% <ø> (ø)`	⬆️
arc/settings.py	`100% <ø> (ø)`	⬆️
arc/job/inputs.py	`100% <ø> (ø)`	⬆️
arc/main.py	`51.31% <ø> (ø)`	⬆️
arc/scheduler.py	`19.86% <12.5%> (+0.01%)`	⬆️
arc/job/job.py	`18.59% <52.94%> (+0.61%)`	⬆️
arc/reaction.py	`41.69% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faed1a0...0a956da. Read the comment docs.

alongd · 2019-06-17T13:35:56Z

Update using memory: {mem} units in Scheduler

- Organized the memory used for each ESS - Added an optional memory attribute to the servers dictionary to limit the requested memory if needed - Modified the memory troubleshooting accordingly

The freq scale factor for wb97xd changed in Arkane, so the thermo we calculate from this restarted job changes accordingly.

alongd force-pushed the memory branch from 58f6936 to f57d561 Compare June 15, 2019 02:33

ReactionMechanismGenerator deleted a comment Jun 15, 2019

alongd force-pushed the memory branch from 6e34524 to f5a3b0e Compare June 15, 2019 13:38

ReactionMechanismGenerator deleted a comment Jun 15, 2019

alongd force-pushed the memory branch from f5a3b0e to 72489fe Compare June 16, 2019 01:07

ReactionMechanismGenerator deleted a comment Jun 16, 2019

alongd force-pushed the memory branch from 72489fe to 7de23c9 Compare June 17, 2019 14:29

ReactionMechanismGenerator deleted a comment Jun 17, 2019

alongd added 2 commits June 17, 2019 10:52

Organized job memory handeling

8d8528b

- Organized the memory used for each ESS - Added an optional memory attribute to the servers dictionary to limit the requested memory if needed - Modified the memory troubleshooting accordingly

Tests: Updated tests to memory units change (MB to GB)

ff0a300

alongd force-pushed the memory branch from 7de23c9 to ff0a300 Compare June 17, 2019 14:52

ReactionMechanismGenerator deleted a comment Jun 17, 2019

Tests: Adapt main test to changes in Arkane

0a956da

The freq scale factor for wb97xd changed in Arkane, so the thermo we calculate from this restarted job changes accordingly.

ReactionMechanismGenerator deleted a comment Jun 17, 2019

alongd merged commit 515462f into master Jun 17, 2019

alongd deleted the memory branch June 17, 2019 20:52

alongd changed the title ~~Organized job memory handeling~~ Organized job memory handling Jul 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Organized job memory handling #137

Organized job memory handling #137

alongd commented Jun 15, 2019

codecov bot commented Jun 15, 2019 •

edited

Loading

alongd commented Jun 17, 2019

Organized job memory handling #137

Organized job memory handling #137

Conversation

alongd commented Jun 15, 2019

codecov bot commented Jun 15, 2019 • edited Loading

Codecov Report

alongd commented Jun 17, 2019

codecov bot commented Jun 15, 2019 •

edited

Loading