-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A new way of thinking about conformers #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alongd
commented
Jul 3, 2019
•
edited
Loading
edited
- Generate non-TS conformers bottom-up instead of top-down
- Use Gromacs with a fitted force field if desired (if species.force_field is set to 'fit')
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 42.93% 45.56% +2.62%
==========================================
Files 27 28 +1
Lines 6118 7223 +1105
Branches 1583 1882 +299
==========================================
+ Hits 2627 3291 +664
- Misses 3110 3462 +352
- Partials 381 470 +89
Continue to review full report at Codecov.
|
Tasks:
|
Start reading after the charge/mult line regardless of number of lines
Go by species.ts_guesses rather than species.conformer_energies
Relocated from Species to Parser
From Scheduler to plotter Made it a function instead of a method so it's easier to test and maintain
For better convergence of the more expensive opt level Aloso, pass memory_gb to job instead of memory for unit consistency
Checking for consistency between xyz, multiplicity and charge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.