Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new way of thinking about conformers #143

Merged
merged 55 commits into from
Jul 25, 2019
Merged

A new way of thinking about conformers #143

merged 55 commits into from
Jul 25, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented Jul 3, 2019

  • Generate non-TS conformers bottom-up instead of top-down
  • Use Gromacs with a fitted force field if desired (if species.force_field is set to 'fit')

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #143 into master will increase coverage by 2.62%.
The diff coverage is 60.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   42.93%   45.56%   +2.62%     
==========================================
  Files          27       28       +1     
  Lines        6118     7223    +1105     
  Branches     1583     1882     +299     
==========================================
+ Hits         2627     3291     +664     
- Misses       3110     3462     +352     
- Partials      381      470      +89
Impacted Files Coverage Δ
arc/job/submit.py 100% <ø> (ø) ⬆️
arc/settings.py 100% <ø> (ø) ⬆️
arc/ts/run_autotst.py 34.28% <0%> (ø) ⬆️
arc/species/__init__.py 100% <100%> (ø) ⬆️
arc/arc_exceptions.py 100% <100%> (ø) ⬆️
arc/parser.py 87.76% <100%> (ø) ⬆️
arc/scheduler.py 18.26% <18.38%> (-0.77%) ⬇️
arc/job/job.py 21.39% <25%> (+0.15%) ⬆️
arc/plotter.py 33.82% <30%> (+3.22%) ⬆️
arc/utils/scale.py 69.14% <43.75%> (-0.98%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fee333...7aff1b0. Read the comment docs.

@alongd
Copy link
Member Author

alongd commented Jul 5, 2019

Tasks:

  • Minimize acpype as much as possible and add tests
  • Conformers tests
  • Todo flags
  • Test conformers in speciesTests
  • Use the Gaussian_SVPFit.out file in testing
  • Report the most stable conformer
  • Chirality translations
  • load conformers yaml file into a species xyz
  • Does it filter by dE threshold?
  • Solve undeterministic symmetry
      File "/home/travis/build/ReactionMechanismGenerator/ARC/arc/species/conformersTest.py", line 808, in test_determine_torsion_symmetry
        for i in range(len(torsions))]), 19)
    AssertionError: 20 != 19```
    
  • Add chiral adjastments to 'gromacs', or remove it... ?

@alongd alongd merged commit 8aa859b into master Jul 25, 2019
@alongd alongd deleted the conformers branch July 25, 2019 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant