Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshoot rotor scans #85

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Troubleshoot rotor scans #85

merged 2 commits into from
Mar 8, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented Mar 8, 2019

By freezing all other dihedrals, also increasing the scan resolution

@alongd alongd added the Type: trsh Troubleshooting label Mar 8, 2019
@alongd
Copy link
Member Author

alongd commented Mar 8, 2019

@mjohnson541, can you try running your molecule on this branch and see if the scan troubleshooting is any good?

@alongd alongd mentioned this pull request Mar 8, 2019
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #85 into master will decrease coverage by 0.13%.
The diff coverage is 6.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage      41%   40.86%   -0.14%     
==========================================
  Files          22       22              
  Lines        4941     4965      +24     
  Branches     1277     1285       +8     
==========================================
+ Hits         2026     2029       +3     
- Misses       2588     2607      +19     
- Partials      327      329       +2
Impacted Files Coverage Δ
arc/job/inputs.py 100% <ø> (ø) ⬆️
arc/job/job.py 21.8% <15.38%> (+0.3%) ⬆️
arc/scheduler.py 18.38% <3.03%> (-0.31%) ⬇️
arc/reaction.py 42.35% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a8e12...6fe9a45. Read the comment docs.

@mjohnson541
Copy link
Collaborator

Yep

alongd added 2 commits March 8, 2019 08:18
by increasing scan resolution and freezing all other dihedrals
@alongd alongd merged commit 88d0b7f into master Mar 8, 2019
@alongd alongd deleted the gaussian_scan branch March 8, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: trsh Troubleshooting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants