-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate resonance structures before checking molecule isomorphism #87
Conversation
In converter, generate resionance structures of copies of mol1 and mol2 by making them RMG:Species objects, then check isomorphism
instead of isIsomorphic()
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 40.86% 40.87% +<.01%
==========================================
Files 22 22
Lines 4965 4969 +4
Branches 1285 1284 -1
==========================================
+ Hits 2029 2031 +2
+ Misses 2609 2607 -2
- Partials 327 331 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 40.86% 40.87% +<.01%
==========================================
Files 22 22
Lines 4965 4969 +4
Branches 1285 1284 -1
==========================================
+ Hits 2029 2031 +2
+ Misses 2609 2607 -2
- Partials 327 331 +4
Continue to review full report at Codecov.
|
e860bad
to
4261af0
Compare
Added to converter. Also first copy the molecule not to change original atom order.