Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly remove forbidden species from edge #1556

Merged
merged 1 commit into from
Feb 24, 2019

Conversation

mjohnson541
Copy link
Contributor

This fixes a bug that occurs when forbidden species are removed from the edge. Currently this is done manually not using removeSpeciesFromEdge which leaves the species and reactions still in memory in more obscure locations leading to key errors later on. This PR switches to using removeSpeciesFromEdge avoiding these problems.

@mjohnson541 mjohnson541 self-assigned this Feb 23, 2019
@mjohnson541 mjohnson541 requested a review from alongd February 23, 2019 02:58
@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #1556 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   41.85%   41.86%   +<.01%     
==========================================
  Files         165      165              
  Lines       28014    28008       -6     
  Branches     5716     5713       -3     
==========================================
  Hits        11726    11726              
+ Misses      15500    15494       -6     
  Partials      788      788
Impacted Files Coverage Δ
rmgpy/rmg/model.py 39.94% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a9ed8d...517fcff. Read the comment docs.

@mjohnson541 mjohnson541 requested review from amarkpayne and removed request for alongd February 24, 2019 21:28
@mjohnson541 mjohnson541 merged commit 22b0d4e into master Feb 24, 2019
@mjohnson541 mjohnson541 deleted the removeforbiddenproperly branch February 24, 2019 21:39
@mliu49 mliu49 mentioned this pull request May 15, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants