Enhanced error message of Arkane GaussianLog loadGeometry #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongd
force-pushed
the
gaussian_load_geometry
branch
from
d07b87e to
46551c1
Compare
alongd
changed the title
|
This looks good to me can you rebase? |
alongd
force-pushed
the
gaussian_load_geometry
branch
from
46551c1 to
2f13133
Compare
Codecov Report
@@ Coverage Diff @@
## master #1562 +/- ##
=======================================
Coverage 41.85% 41.85%
=======================================
Files 165 165
Lines 28007 28007
Branches 5713 5713
=======================================
Hits 11721 11721
Misses 15497 15497
Partials 789 789Continue to review full report at Codecov.
|
|
rebased |
|
ready to be merged |
|
This minor PR is ready to be merged. Could anyone approve it? |
mliu49
approved these changes
Mar 27, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error massage of the loadGeometry method in Arkane's GaussianLog class was elaborated. If a species has more than 50 atoms, users should add the
iop(2/9=2000)keyword to the input file for ask Gaussian to print the input orientation geometry.