Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise a DASxError if nan found in moles #1679

Merged
merged 2 commits into from
Aug 9, 2019
Merged

raise a DASxError if nan found in moles #1679

merged 2 commits into from
Aug 9, 2019

Conversation

mjohnson541
Copy link
Contributor

Helps RMG diagnose #1678 more sensibly.

@mjohnson541 mjohnson541 requested a review from mliu49 August 9, 2019 18:33
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #1679 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
+ Coverage   41.79%   41.81%   +0.01%     
==========================================
  Files         177      177              
  Lines       30207    30207              
  Branches     6252     6252              
==========================================
+ Hits        12625    12630       +5     
+ Misses      16659    16655       -4     
+ Partials      923      922       -1
Impacted Files Coverage Δ
rmgpy/data/kinetics/family.py 48.91% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1029f90...0c276ca. Read the comment docs.

@mliu49 mliu49 merged commit 04d4d42 into master Aug 9, 2019
@mliu49 mliu49 deleted the raiseDASxErrorOnNan branch August 9, 2019 20:54
@mliu49 mliu49 mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants