Allow generate_reactions.py script to accept number of processors #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a command line argument
Codecov Report
@@ Coverage Diff @@
## master #1780 +/- ##
======================================
Coverage 32.6% 32.6%
======================================
Files 87 87
Lines 26116 26116
Branches 6875 6875
======================================
Hits 8516 8516
Misses 16630 16630
Partials 970 970
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
This pull request resolves #1779
Description of Changes
'maxproc': args.maxproc, was added as an entry to the kwargs dictionary in generate_reactions.py
Testing
"python ~/RMG-Py/scripts/generateReactions.py -n 1 input.py" will print the expected "For reaction generation, 1 process is used" from react.py
"python ~/RMG-Py/scripts/generateReactions.py -n 2 input.py" will now print the expected "For reaction generation, 2 processes are used" from react.py
Activity monitor confirms that 2 processes are being used and indeed the run time is faster
Reviewer Tips
All feedback and suggestions are welcome :)