Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PES figure generation in png format #1802

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Fix PES figure generation in png format #1802

merged 1 commit into from
Nov 5, 2019

Conversation

xiaoruiDong
Copy link
Contributor

@xiaoruiDong xiaoruiDong commented Nov 1, 2019

Motivation or Problem

One of the arguments of rmgpy.pdep.draw is renamed from format to file_format in a previous commit, but the corresponding codes are not fully refactorized, causing failures in generating PES figures in png format. This will further hinder the PES from being generated and displayed on the RMG-website.

Description of Changes

rename format to file_format .

Testing

By calling the draw function with file_format="png", it can generate PES figure in .png format

Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!
Could you also fix the docstring on line 241 (format to file_format as well)?

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a1f63f3). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1802   +/-   ##
=========================================
  Coverage          ?   42.74%           
=========================================
  Files             ?       81           
  Lines             ?    21078           
  Branches          ?     5491           
=========================================
  Hits              ?     9010           
  Misses            ?    11054           
  Partials          ?     1014
Impacted Files Coverage Δ
rmgpy/pdep/draw.py 4.33% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f63f3...9361445. Read the comment docs.

@xiaoruiDong
Copy link
Contributor Author

Thanks @alongd. Docstring changed as well.

Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alongd alongd merged commit 6b2555a into master Nov 5, 2019
@alongd alongd deleted the fix_pdep_png_plot branch November 5, 2019 15:48
@mliu49 mliu49 mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants