Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sensitivity example for py3 #1805

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

oscarwumit
Copy link
Contributor

Motivation or Problem

Update sensitivity example as part of py3 merge task.

Description of Changes

  1. correct the format of chemkin input file in the example, before it resulted in a parser error
    "Thermo file has no default temperature ranges
    (The line it would be on is ' 300.000 1000.000 5000.000\n' but that is not formatted as such)
    "
  2. removed legacy exclusion mark for kinetics families

Testing

Tested the example locally. The sensitivity analysis finished successfully.

yunsiechung
yunsiechung previously approved these changes Nov 4, 2019
Copy link
Contributor

@yunsiechung yunsiechung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #1805 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1805   +/-   ##
=======================================
  Coverage   42.99%   42.99%           
=======================================
  Files          80       80           
  Lines       21090    21090           
  Branches     5513     5513           
=======================================
  Hits         9067     9067           
  Misses      11008    11008           
  Partials     1015     1015

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f9382...e8b88be. Read the comment docs.

Two updates for the sensitivity example:

1. correct the format of chemkin input file in the example, before it resulted in a parser error
"Thermo file has no default temperature ranges
(The line it would be on is '    300.000  1000.000  5000.000\n' but that is not formatted as such)
"

2. removed legacy exclusion mark for kinetics families
@oscarwumit oscarwumit force-pushed the sensitivity_py3_example_update branch from 9c86874 to e8b88be Compare November 7, 2019 15:48
Copy link
Contributor

@yunsiechung yunsiechung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@oscarwumit
Copy link
Contributor Author

@amarkpayne could you please merge this PR? I do not have merge access.Thanks.

@mjohnson541 mjohnson541 merged commit a38eaf3 into master Nov 7, 2019
@mjohnson541 mjohnson541 deleted the sensitivity_py3_example_update branch November 7, 2019 18:13
@mliu49 mliu49 mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants