-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update isotope documentation #1807
Conversation
39525f8
to
dbc2baa
Compare
Codecov Report
@@ Coverage Diff @@
## master #1807 +/- ##
=======================================
Coverage 43.02% 43.02%
=======================================
Files 80 80
Lines 21099 21099
Branches 5516 5516
=======================================
Hits 9077 9077
+ Misses 11004 10990 -14
- Partials 1018 1032 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added minor comments
|
||
A description of mechanisms generated using this module and its application to | ||
obtaining intramolecular isotopic enrichment information is described in | ||
Chemical Geology, Volume 514, page 1, doi: https://doi.org/10.1016/j.chemgeo.2019.02.036 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you make these doi's clickable?
use this example format for rst:
`Molpro <https://www.molpro.net/>`_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed and checked to ensure it built properly with links
This commit updates the isotope documentation by linking a publication and its corresponding scripts, as well as mentioning a caveat when regenerating all the reactions from the start.
dbc2baa
to
2d0def3
Compare
This commit updates the isotope documentation by linking a publication
and its corresponding scripts, as well as mentioning a caveat when
regenerating all the reactions from the start.
Testing
Built locally, checked spelling, viewed in browser, made sure links function
Reviewer Tips
See if the writing makes sense.