Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA commands to group logs #224

Merged

Conversation

michaelkaye
Copy link
Contributor

Suggest reviewing with diff -w as the majority of the change is whitespace indentation.

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines

@michaelkaye michaelkaye marked this pull request as ready for review February 16, 2022 12:24
@michaelkaye
Copy link
Contributor Author

michaelkaye commented Feb 16, 2022

New split looks like this, saving ~120 lines or so at least :)

Summary

@ychescale9
Copy link
Member

ychescale9 commented Feb 16, 2022

Looks great! Can you run npm run build and check in the generated js files?

@michaelkaye
Copy link
Contributor Author

Er, maybe; I don't have a npm setup locally I can use for this; I'd have to knock something up with docker or similar (which is why i like the draft PR as a way to lint and compile using the GHA :)

I'll see if i can sort it out soon, otherwise feel free to take the change and push it live.

@ychescale9
Copy link
Member

No worries I can take over. Thanks again for the great contribution!

@ychescale9 ychescale9 merged commit 1e2ef72 into ReactiveCircus:main Feb 17, 2022
@michaelkaye michaelkaye deleted the michaelk/group_log_lines branch February 17, 2022 10:54
ychescale9 added a commit that referenced this pull request Feb 17, 2022
* main:
  Prepare for release 2.23.0.
  Add missing generated .js files.
  Add GHA commands to group logs (#224)
  wikimedia have likely renamed master -> main (#221)
  Allow increasing main storage size (sdcard is separate storage) (#219)
  Update to SDK command-line tools 6.0. (#213)
  Update build tools to 32.0.0. Update text-fixture compileSdkVersion and targetSdkVersion to 32. (#212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants