Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring in Signal. #113

Closed
wants to merge 3 commits into from
Closed

Minor refactoring in Signal. #113

wants to merge 3 commits into from

Conversation

andersio
Copy link
Member

@andersio andersio commented Nov 24, 2016 •
edited
Loading

  1. Drop NSLocks to be in line with Atomic. (it is slower than pthread mutexes on Darwin due to dynamic dispatching)
  2. Break the SignalState to reduce unnecessary retains and releases caused by the signal self reference.

@andersio andersio mentioned this pull request Nov 25, 2016
Closed
@andersio andersio closed this Nov 25, 2016
@andersio andersio deleted the minor-refactor-signal branch November 25, 2016 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andersio