Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate strategy and remove NoError constraint from flatten when the value is a Sequence #199

Conversation

dmcrodrigues
Copy link
Contributor

@dmcrodrigues dmcrodrigues commented Dec 30, 2016

Fixes #198. Originally suggested in #197.

@dmcrodrigues dmcrodrigues force-pushed the dr/remove-strategy-and-noerror-from-flatten-when-the-value-is-a-sequence branch from 2613436 to a024c4e Compare December 30, 2016 08:59
@dmcrodrigues dmcrodrigues changed the base branch from master-next to master December 30, 2016 12:37
@andersio andersio closed this Dec 30, 2016
@andersio andersio reopened this Dec 30, 2016
Copy link
Member

@andersio andersio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dmcrodrigues dmcrodrigues changed the title Remove strategy and NoError from flatten when the value is a Sequence Deprecate strategy and remove NoError constraint from flatten when the value is a Sequence Dec 30, 2016
@andersio andersio requested a review from mdiep December 30, 2016 13:02
@RuiAAPeres RuiAAPeres merged commit fd61caf into ReactiveCocoa:master Jan 3, 2017
@dmcrodrigues dmcrodrigues deleted the dr/remove-strategy-and-noerror-from-flatten-when-the-value-is-a-sequence branch January 3, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants