Add CI Release jobs on tag push #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently the CP validation is failing due to CocoaPods/CocoaPods#11558, which has been fixed in CocoaPods/CocoaPods#11660 but not released yet |
mluisbrown
approved these changes
Dec 6, 2022
## Changes - Update `master.yml` GH Actions workflow to be triggered on version tag pushes (i.e. `x.y.z`, `x.y.z-rc.w`). - Add new `release-github` and `release-cocoapods` jobs on `master.yml` to do GH and CP releases on tag pushes, respectively. - Update macOS image to `macos-12` and Xcode to 14.1 on `master.yml` to be consistent with `test.yml`. - Add some missing names to jobs and rename others. - Update `script/carthage` to have a var with the Xcode major version (`XCODE_VERSION_MAJOR`) on the `EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_simulator__NATIVE_ARCH_64_BIT_x86_64__XCODE_<XXXX>` setting which can't be defined dynamically. - Update Nimble to 9.2.1 to fix duplicate symbol error in Release builds (Xcode 14). - Keep using Xcode 13 in `master.yml` until CP releases the fix for watchOS verification on Xcode 14: - CocoaPods/CocoaPods#11558 - CocoaPods/CocoaPods#11660 - Remove `.swift-version` file
p4checo
force-pushed
the
add-ci-release-jobs-on-tag-push
branch
from
cfea3ac
to
21c9d86
Compare
mluisbrown
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update
master.ymlGH Actions workflow to be triggered on version tag pushes (i.e.x.y.z,x.y.z-rc.w).Add new
release-githubandrelease-cocoapodsjobs onmaster.ymlto do GH and CP releases on tag pushes, respectively.Update macOS image to
macos-12and Xcode to 14.1 onmaster.ymlto be consistent withtest.yml.Add some missing names to jobs and rename others.
Checklist