-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_catch vs catch breaks ESM code built against the rxjs umd bundle #1924
Comments
For our reference, these are all the operators I could find that would have this problem:
|
@IgorMinar Just so we have all the bases covered with full context, are you not adding the operators to an Observable prototype because you want absolutely no operators on them by default? |
@jayphelps correct. we don't want loading of Angular's router to have a side-effect of monkey-patching the Observable prototype. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
RxJS version:
beta.11
Code to reproduce:
full source: https://github.com/angular/angular/blob/ee88c3c976654f15d41f8d35345ad96026fe5fe8/modules/%40angular/router/src/apply_redirects.ts#L14
full source: https://github.com/angular/angular/blob/ee88c3c976654f15d41f8d35345ad96026fe5fe8/modules/%40angular/router/rollup.config.js#L30
Expected behavior:
the router bundle should be able to get hold of the
_catch
operator from the prototype via_catch
property.Actual behavior:
the
_catch
operator is not found because in the UMD bundle it was exported ascatch
(without the leading underscore).Additional information:
Angular router bug that first raised this issue: angular/angular#11300
Reproduction: http://plnkr.co/edit/aSPFwbLNxlT5sQzSyGIN?p=preview
The text was updated successfully, but these errors were encountered: