Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on complete when using .bufferTime().take() and supplying a maxBufferSize #1944

Closed
sbm007 opened this issue Sep 14, 2016 · 2 comments · Fixed by #1998
Closed

Error on complete when using .bufferTime().take() and supplying a maxBufferSize #1944

sbm007 opened this issue Sep 14, 2016 · 2 comments · Fixed by #1998
Assignees

Comments

@sbm007
Copy link

sbm007 commented Sep 14, 2016

RxJS version:
rxjs@5.0.0-beta.12

Code to reproduce:
jsbin example

Rx.Observable.interval(100)
  .bufferTime(1000, null, 5)
  .take(5)
  .subscribe(console.log.bind(console.log));

Expected behavior:
Stream should complete without any errors.

Actual behavior:
Throws a TypeError on complete:

Uncaught TypeError: Cannot read property 'push' of null
    BufferTimeSubscriber.openContext @ Rx.js:6288
    BufferTimeSubscriber.onBufferFull @ Rx.js:6280
    BufferTimeSubscriber._next @ Rx.js:6256
    Subscriber.next @ Rx.js:1301

Additional information:

@kwonoj
Copy link
Member

kwonoj commented Sep 14, 2016

Thanks for report. as I did similar changes to guard, let me take a look at this as well.

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants