Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typings): updated typings for combineAll, mergeAll, concatAll, switch, exhaust, zipAll #3321

Merged

Conversation

david-driscoll
Copy link
Member

@david-driscoll david-driscoll commented Feb 15, 2018

Description:

This adds support for nested observables using some of the newest features of the TypeScript
compiler. Things like like the following that were impossible before will now work correctly!

const source1 = Rx.Observable.of(1, 2, 3);
const source2 = [1, 2, 3];
const source3 = new Promise<number>(d => d(1));

let result: Rx.Observable<number[]> = Rx.Observable
      .of(source1, source2, source3)
      .zipAll();

// or

let result: Rx.Observable<number[]> = Rx.Observable
  .of(source1, source2, source3)
  .pipe(Rx.operators.zipAll());

Also updated tests in related areas.

@rxjs-bot
Copy link

rxjs-bot commented Feb 15, 2018

Warnings
⚠️

❗ Big PR (1)

Messages
📖

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

CJS: 1358.2KB, global: 726.4KB (gzipped: 117.3KB), min: 140.3KB (gzipped: 30.6KB)

Generated by 🚫 dangerJS

…witch, exhaust, zipAll

    this adds support for nested observables using some of the newest features of the TypeScript
    compiler.  Also updated tests in related areas
@coveralls
Copy link

coveralls commented Feb 15, 2018

Coverage Status

Coverage remained the same at 97.502% when pulling 671627f on david-driscoll:typings-combine-all-the-things into 4a86541 on ReactiveX:master.

@martinsik
Copy link
Contributor

I'm just curious if this fixes issue like this #2759 or this #3290.

@david-driscoll
Copy link
Member Author

@martinsik looking at those issues, yes it will.
I hadn't gone through the issue list yet to find any open issues that would be fixed, I was just fixing errors round in the unit tests (which aren't currently compiled with strong types).

@benlesh
Copy link
Member

benlesh commented Feb 20, 2018

Thanks @david-driscoll!

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants