Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rxjs and rxjs-es6 publishing issues #845

Closed
benlesh opened this issue Dec 1, 2015 · 6 comments
Closed

rxjs and rxjs-es6 publishing issues #845

benlesh opened this issue Dec 1, 2015 · 6 comments

Comments

@benlesh
Copy link
Member

benlesh commented Dec 1, 2015

  1. Right now the package.json files that are being copied to the dist/es6 and dist/cjs directories have a prepublish step that tries to build the source. That, of course, fails.
  2. There are no READMEs for these two packages. So it looks bad/wrong on npmjs.org.

cc/ @robwormald
@robwormald
Copy link
Contributor

fail.

@robwormald
Copy link
Contributor

assign to me?

@benlesh
Copy link
Member Author

benlesh commented Dec 1, 2015

Can't you're not in the org. I'll assign to me, and pester you about it.

@benlesh benlesh self-assigned this Dec 1, 2015
@robwormald
Copy link
Contributor

also fix the license copy

@jeffbcross jeffbcross mentioned this issue Dec 2, 2015
Closed
@jeffbcross jeffbcross assigned jeffbcross and unassigned benlesh Dec 4, 2015
@jeffbcross
Copy link
Contributor

I'm taking this on

jeffbcross added a commit to jeffbcross/RxJS that referenced this issue Dec 4, 2015
@jeffbcross
fix(publish): copy readme and license, remove scripts
a778fb4 
This change makes sure the README.md and LICENSE.txt files are
included in the CJS and ES6 distributions. The change also
removes all scripts from the npm package, since no scripts are
expectd to be run when installed by end-users.

Fixes ReactiveX#845
jeffbcross added a commit to jeffbcross/RxJS that referenced this issue Dec 4, 2015
@jeffbcross
fix(publish): copy readme and license, remove scripts
439a2f3 
This change makes sure the README.md and LICENSE.txt files are
included in the CJS and ES6 distributions. The change also
removes all scripts from the npm package, since no scripts are
expectd to be run when installed by end-users.

Fixes ReactiveX#845
@jeffbcross jeffbcross mentioned this issue Dec 4, 2015
Merged
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot unassigned jeffbcross Jun 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffbcross @robwormald @benlesh