Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Should Observable.compose() use its ObservableTransformer? #4656

Closed
dlew opened this issue Oct 1, 2016 · 3 comments
Closed

2.x: Should Observable.compose() use its ObservableTransformer? #4656

dlew opened this issue Oct 1, 2016 · 3 comments
Labels
PR welcome

Comments

@dlew
Copy link

dlew commented Oct 1, 2016

Along the same lines as #4650, is there a reason why Observable.compose() doesn't use the (already in existence) ObservableTransformer?
@akarnokd
Copy link
Member

akarnokd commented Oct 1, 2016

Yes.

@akarnokd
Copy link
Member

akarnokd commented Oct 1, 2016

It was simply overlooked. PR velcome

@dlew
Copy link
Author

dlew commented Oct 2, 2016

Thanks for fixing this in #4658.

@dlew dlew closed this as completed Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlew @akarnokd