2.x: Observable.compose to use ObservableTransformer #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 77.83% (diff: 100%)@@ 2.x #4658 diff @@
==========================================
Files 559 559
Lines 36654 36654
Methods 0 0
Messages 0 0
Branches 5625 5625
==========================================
- Hits 28579 28530 -49
- Misses 6044 6088 +44
- Partials 2031 2036 +5
|
JakeWharton
approved these changes
Oct 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
Observable.composetype toObservableTransformerto reduce the type-argument/inference problem. The other base types have been previously updated to their respective transfomer types.