Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 2.x Copyright to "RxJava Contributors" #4978

Closed
benjchristensen opened this issue Jan 9, 2017 · 6 comments
Closed

Change 2.x Copyright to "RxJava Contributors" #4978

benjchristensen opened this issue Jan 9, 2017 · 6 comments
Labels

Comments

@benjchristensen
Copy link
Member

I noticed that the 2.x copyright still shows as Netflix, despite Netflix no longer leading the efforts of the project (since I left Netflix over a year ago).

Since the 2.x code has been re-written from scratch outside the leadership of Netflix, I suggest that the copyright headers all be replaced with:

Copyright (c) 2016-present, RxJava Contributors. 

This would replace this line at the top of every file:

Copyright 2016 Netflix, Inc.

The precedent for this is shown by the Facebook project Yarn which is a community driven project from many companies, not just Facebook: https://github.com/yarnpkg/yarn/blob/master/LICENSE

Since that is how RxJava is being managed, I think it's a good change to make.

cc @stevegury, @abersnaze, and @NiteshKant from Netflix who are the closest to RxJava from the v1.x time frame and who were involved in the initial design of 2.x and choice to handoff the project to the community and @akarnokd as the lead.

@benjchristensen
Copy link
Member Author

Alright, based on the thumbs up ... should I submit a PR? cc @akarnokd in particular for answering whether you want me to submit this, or you do the change?

@JakeWharton
Copy link
Contributor

For RxAndroid we use "The RxAndroid authors", but I'm happy to normalize that to whatever is chosen here.

@akarnokd
Copy link
Member

akarnokd commented Jan 9, 2017

@benjchristensen Sure.

benjchristensen added a commit to benjchristensen/RxJava that referenced this issue Jan 9, 2017
@stevegury
Copy link
Member

LGTM

akarnokd pushed a commit that referenced this issue Jan 9, 2017
@fanturbo
Copy link

fanturbo commented Jan 10, 2017

@benjchristensen Maybe you forget to change README.md?

@akarnokd
Copy link
Member

All updated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants