Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest Maybe#toSingle in Maybe#defaultIfEmpty documentation #5480

Closed
alexeyr opened this issue Jul 11, 2017 · 2 comments
Closed

Suggest Maybe#toSingle in Maybe#defaultIfEmpty documentation #5480

alexeyr opened this issue Jul 11, 2017 · 2 comments
Labels
2.x Documentation PR welcome
Milestone
2.2

Comments

@alexeyr
Copy link

alexeyr commented Jul 11, 2017

Looking at http://reactivex.io/RxJava/2.x/javadoc/io/reactivex/Maybe.html#defaultIfEmpty%28T%29, I was surprised to find it didn't return Single. Searching in closed issues found the answer: #5417. Perhaps documentation could be improved by explicitly mentioning toSingle as an alternative?
@akarnokd
Copy link
Member

PR welcome.

@akarnokd akarnokd added this to the 2.2 milestone Jul 11, 2017
alexeyr added a commit to alexeyr/RxJava that referenced this issue Jul 12, 2017
@alexeyr
Improve Maybe#defaultIfEmpty javadoc (ReactiveX#5480)
11ab2ee
alexeyr added a commit to alexeyr/RxJava that referenced this issue Jul 12, 2017
@alexeyr
Update Maybe#defaultIfEmpty javadoc (ReactiveX#5480)
7f71dd8
@alexeyr alexeyr mentioned this issue Jul 12, 2017
Closed
@akarnokd akarnokd mentioned this issue Jul 12, 2017
Merged
@akarnokd
Copy link
Member

Closing via #5486.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Documentation PR welcome
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
2 participants
@alexeyr @akarnokd