Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: fix typo in BehaviorSubject.java #7452

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

harrygaoos
Copy link
Contributor

@harrygaoos harrygaoos commented Jul 19, 2022

Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:

  • Please give a description about what and why you are contributing, even if it's trivial.
    Fixed typo below:
 * observable.onNext(1);
 * // this will "clear" the cache
 * observable.onNext(EMPTY);

to

 * subject.onNext(1);
 * // this will "clear" the cache
 * subject.onNext(EMPTY);

observable has no #onNext() method.

  • Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.

  • Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an empty, just, range of values as well as an error source, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #7452 (39438c1) into 3.x (f980960) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.x    #7452      +/-   ##
============================================
+ Coverage     99.53%   99.54%   +0.01%     
+ Complexity     6782     6781       -1     
============================================
  Files           751      751              
  Lines         47482    47482              
  Branches       6378     6378              
============================================
+ Hits          47261    47267       +6     
+ Misses          101       97       -4     
+ Partials        120      118       -2     
Impacted Files Coverage Δ
...io/reactivex/rxjava3/subjects/BehaviorSubject.java 100.00% <ø> (ø)
...xjava3/internal/observers/FutureMultiObserver.java 96.61% <0.00%> (-3.39%) ⬇️
...va/io/reactivex/rxjava3/subjects/AsyncSubject.java 97.87% <0.00%> (-2.13%) ⬇️
...java3/internal/operators/flowable/FlowableZip.java 98.97% <0.00%> (-1.03%) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 95.23% <0.00%> (-0.80%) ⬇️
...a/io/reactivex/rxjava3/subjects/ReplaySubject.java 98.96% <0.00%> (-0.21%) ⬇️
...a3/internal/operators/flowable/FlowableCreate.java 99.35% <0.00%> (+0.32%) ⬆️
...a3/internal/operators/flowable/FlowableReplay.java 99.78% <0.00%> (+0.85%) ⬆️
...3/internal/operators/flowable/FlowablePublish.java 100.00% <0.00%> (+0.99%) ⬆️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 97.92% <0.00%> (+1.55%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@akarnokd akarnokd merged commit 8473610 into ReactiveX:3.x Jul 19, 2022
@akarnokd
Copy link
Member

Thanks!

Goooler referenced this pull request in Goooler/DemoApp Jan 18, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) |
`3.1.5` -> `3.1.6` |
[![age](https://badges.renovateapi.com/packages/maven/io.reactivex.rxjava3:rxjava/3.1.6/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/maven/io.reactivex.rxjava3:rxjava/3.1.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/maven/io.reactivex.rxjava3:rxjava/3.1.6/compatibility-slim/3.1.5)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/maven/io.reactivex.rxjava3:rxjava/3.1.6/confidence-slim/3.1.5)](https://docs.renovatebot.com/merge-confidence/)
|

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>ReactiveX/RxJava</summary>

###
[`v3.1.6`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.6)


[Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.6%7C)
[JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.6)

##### API changes

- Add an overload to `throttleLatest` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7457'>[#&#8203;7457](https://togithub.com/ReactiveX/RxJava/issues/7457)</a>)
- Add an overload to `throttleFirst` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7482'>[#&#8203;7482](https://togithub.com/ReactiveX/RxJava/issues/7482)</a>)
- Add an overload to `throttleLast` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7488'>[#&#8203;7488](https://togithub.com/ReactiveX/RxJava/issues/7488)</a>)
- Add an overload to `throttleWithTimeout` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7510'>[#&#8203;7510](https://togithub.com/ReactiveX/RxJava/issues/7510)</a>)

##### Bugfixes

- Fix a race condition in `Single.timeout` that prevented the timeout
signal from happening. (<a
href='https://github.com/ReactiveX/RxJava/issues/7515'>[#&#8203;7515](https://togithub.com/ReactiveX/RxJava/issues/7515)</a>)

##### Documentation

- Fix formatting in `TestObserver/Consumer/Subscriber` javadoc html. (<a
href='https://github.com/ReactiveX/RxJava/issues/7442'>[#&#8203;7442](https://togithub.com/ReactiveX/RxJava/issues/7442)</a>)
- Fix typo in `BehaviorSubject.java`. (<a
href='https://github.com/ReactiveX/RxJava/issues/7452'>[#&#8203;7452](https://togithub.com/ReactiveX/RxJava/issues/7452)</a>)
- Fix grammar about cancellation in `Schedulers` javadoc. (<a
href='https://github.com/ReactiveX/RxJava/issues/7453'>[#&#8203;7453](https://togithub.com/ReactiveX/RxJava/issues/7453)</a>)
- Change `@coded` tag to `@code` tag. (<a
href='https://github.com/ReactiveX/RxJava/issues/7463'>[#&#8203;7463](https://togithub.com/ReactiveX/RxJava/issues/7463)</a>)
- Fix `fromCompletionStage` javadoc. (<a
href='https://github.com/ReactiveX/RxJava/issues/7508'>[#&#8203;7508](https://togithub.com/ReactiveX/RxJava/issues/7508)</a>)

##### Other

- Add missing `@NonNull` annotation to `Maybe` type argument. (<a
href='https://github.com/ReactiveX/RxJava/issues/7436'>[#&#8203;7436](https://togithub.com/ReactiveX/RxJava/issues/7436)</a>)
- Remove redundant interface declarations. (<a
href='https://github.com/ReactiveX/RxJava/issues/7438'>[#&#8203;7438](https://togithub.com/ReactiveX/RxJava/issues/7438)</a>)
- Standardize `MissingBackpressureException` message, introduce
`QueueOverflowException`. (<a
href='https://github.com/ReactiveX/RxJava/issues/7459'>[#&#8203;7459](https://togithub.com/ReactiveX/RxJava/issues/7459)</a>)
- Update `Flowable.throttleLatest` `MissingBackpressureException`
message. (<a
href='https://github.com/ReactiveX/RxJava/issues/7460'>[#&#8203;7460](https://togithub.com/ReactiveX/RxJava/issues/7460)</a>)
- Fix cancellation order in `throttleFirst`. (<a
href='https://github.com/ReactiveX/RxJava/issues/7484'>[#&#8203;7484](https://togithub.com/ReactiveX/RxJava/issues/7484)</a>)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Goooler/DemoApp).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDUuMyIsInVwZGF0ZWRJblZlciI6IjM0LjEwNS4zIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ZacSweers referenced this pull request in slackhq/circuit Jan 19, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) |
dependencies | patch | `3.1.5` -> `3.1.6` |

---

### Release Notes

<details>
<summary>ReactiveX/RxJava</summary>

###
[`v3.1.6`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.6)


[Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.6%7C)
[JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.6)

##### API changes

- Add an overload to `throttleLatest` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7457'>[#&#8203;7457](https://togithub.com/ReactiveX/RxJava/issues/7457)</a>)
- Add an overload to `throttleFirst` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7482'>[#&#8203;7482](https://togithub.com/ReactiveX/RxJava/issues/7482)</a>)
- Add an overload to `throttleLast` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7488'>[#&#8203;7488](https://togithub.com/ReactiveX/RxJava/issues/7488)</a>)
- Add an overload to `throttleWithTimeout` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7510'>[#&#8203;7510](https://togithub.com/ReactiveX/RxJava/issues/7510)</a>)

##### Bugfixes

- Fix a race condition in `Single.timeout` that prevented the timeout
signal from happening. (<a
href='https://github.com/ReactiveX/RxJava/issues/7515'>[#&#8203;7515](https://togithub.com/ReactiveX/RxJava/issues/7515)</a>)

##### Documentation

- Fix formatting in `TestObserver/Consumer/Subscriber` javadoc html. (<a
href='https://github.com/ReactiveX/RxJava/issues/7442'>[#&#8203;7442](https://togithub.com/ReactiveX/RxJava/issues/7442)</a>)
- Fix typo in `BehaviorSubject.java`. (<a
href='https://github.com/ReactiveX/RxJava/issues/7452'>[#&#8203;7452](https://togithub.com/ReactiveX/RxJava/issues/7452)</a>)
- Fix grammar about cancellation in `Schedulers` javadoc. (<a
href='https://github.com/ReactiveX/RxJava/issues/7453'>[#&#8203;7453](https://togithub.com/ReactiveX/RxJava/issues/7453)</a>)
- Change `@coded` tag to `@code` tag. (<a
href='https://github.com/ReactiveX/RxJava/issues/7463'>[#&#8203;7463](https://togithub.com/ReactiveX/RxJava/issues/7463)</a>)
- Fix `fromCompletionStage` javadoc. (<a
href='https://github.com/ReactiveX/RxJava/issues/7508'>[#&#8203;7508](https://togithub.com/ReactiveX/RxJava/issues/7508)</a>)

##### Other

- Add missing `@NonNull` annotation to `Maybe` type argument. (<a
href='https://github.com/ReactiveX/RxJava/issues/7436'>[#&#8203;7436](https://togithub.com/ReactiveX/RxJava/issues/7436)</a>)
- Remove redundant interface declarations. (<a
href='https://github.com/ReactiveX/RxJava/issues/7438'>[#&#8203;7438](https://togithub.com/ReactiveX/RxJava/issues/7438)</a>)
- Standardize `MissingBackpressureException` message, introduce
`QueueOverflowException`. (<a
href='https://github.com/ReactiveX/RxJava/issues/7459'>[#&#8203;7459](https://togithub.com/ReactiveX/RxJava/issues/7459)</a>)
- Update `Flowable.throttleLatest` `MissingBackpressureException`
message. (<a
href='https://github.com/ReactiveX/RxJava/issues/7460'>[#&#8203;7460](https://togithub.com/ReactiveX/RxJava/issues/7460)</a>)
- Fix cancellation order in `throttleFirst`. (<a
href='https://github.com/ReactiveX/RxJava/issues/7484'>[#&#8203;7484](https://togithub.com/ReactiveX/RxJava/issues/7484)</a>)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTAuNiIsInVwZGF0ZWRJblZlciI6IjMyLjE5MC42In0=-->
ZacSweers referenced this pull request in slackhq/foundry Jan 19, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) |
dependencies | patch | `3.1.5` -> `3.1.6` |

---

### Release Notes

<details>
<summary>ReactiveX/RxJava</summary>

###
[`v3.1.6`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.6)


[Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.6%7C)
[JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.6)

##### API changes

- Add an overload to `throttleLatest` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7457'>[#&#8203;7457](https://togithub.com/ReactiveX/RxJava/issues/7457)</a>)
- Add an overload to `throttleFirst` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7482'>[#&#8203;7482](https://togithub.com/ReactiveX/RxJava/issues/7482)</a>)
- Add an overload to `throttleLast` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7488'>[#&#8203;7488](https://togithub.com/ReactiveX/RxJava/issues/7488)</a>)
- Add an overload to `throttleWithTimeout` operator with an `onDropped`
callback. (<a
href='https://github.com/ReactiveX/RxJava/issues/7510'>[#&#8203;7510](https://togithub.com/ReactiveX/RxJava/issues/7510)</a>)

##### Bugfixes

- Fix a race condition in `Single.timeout` that prevented the timeout
signal from happening. (<a
href='https://github.com/ReactiveX/RxJava/issues/7515'>[#&#8203;7515](https://togithub.com/ReactiveX/RxJava/issues/7515)</a>)

##### Documentation

- Fix formatting in `TestObserver/Consumer/Subscriber` javadoc html. (<a
href='https://github.com/ReactiveX/RxJava/issues/7442'>[#&#8203;7442](https://togithub.com/ReactiveX/RxJava/issues/7442)</a>)
- Fix typo in `BehaviorSubject.java`. (<a
href='https://github.com/ReactiveX/RxJava/issues/7452'>[#&#8203;7452](https://togithub.com/ReactiveX/RxJava/issues/7452)</a>)
- Fix grammar about cancellation in `Schedulers` javadoc. (<a
href='https://github.com/ReactiveX/RxJava/issues/7453'>[#&#8203;7453](https://togithub.com/ReactiveX/RxJava/issues/7453)</a>)
- Change `@coded` tag to `@code` tag. (<a
href='https://github.com/ReactiveX/RxJava/issues/7463'>[#&#8203;7463](https://togithub.com/ReactiveX/RxJava/issues/7463)</a>)
- Fix `fromCompletionStage` javadoc. (<a
href='https://github.com/ReactiveX/RxJava/issues/7508'>[#&#8203;7508](https://togithub.com/ReactiveX/RxJava/issues/7508)</a>)

##### Other

- Add missing `@NonNull` annotation to `Maybe` type argument. (<a
href='https://github.com/ReactiveX/RxJava/issues/7436'>[#&#8203;7436](https://togithub.com/ReactiveX/RxJava/issues/7436)</a>)
- Remove redundant interface declarations. (<a
href='https://github.com/ReactiveX/RxJava/issues/7438'>[#&#8203;7438](https://togithub.com/ReactiveX/RxJava/issues/7438)</a>)
- Standardize `MissingBackpressureException` message, introduce
`QueueOverflowException`. (<a
href='https://github.com/ReactiveX/RxJava/issues/7459'>[#&#8203;7459](https://togithub.com/ReactiveX/RxJava/issues/7459)</a>)
- Update `Flowable.throttleLatest` `MissingBackpressureException`
message. (<a
href='https://github.com/ReactiveX/RxJava/issues/7460'>[#&#8203;7460](https://togithub.com/ReactiveX/RxJava/issues/7460)</a>)
- Fix cancellation order in `throttleFirst`. (<a
href='https://github.com/ReactiveX/RxJava/issues/7484'>[#&#8203;7484](https://togithub.com/ReactiveX/RxJava/issues/7484)</a>)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTAuNiIsInVwZGF0ZWRJblZlciI6IjMyLjE5MC42In0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants