-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: flatMap{Completable, Maybe, Single} operators #4667
Conversation
The build gets killed at the jacocoTestResults:
I've rerun it a couple of times. Maybe Travis is overloaded at the moment. |
Current coverage is 82.13% (diff: 72.71%)@@ 2.x #4667 diff @@
==========================================
Files 557 565 +8
Lines 36402 37399 +997
Methods 0 0
Messages 0 0
Branches 5568 5746 +178
==========================================
+ Hits 29974 30716 +742
- Misses 4437 4607 +170
- Partials 1991 2076 +85
|
Updated with the remaining operators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My brain melted slightly reviewing these operators, but looks good.
Thanks a lot for taking this one over @akarnokd |
This PR adds
Observable.flatMapCompletable(Function<T, CompletableSource>)
andFlowable.flatMapCompletable(Function<T, CompletableSource>)
, both resulting inCompletable
(+ support for fusing back to the original type).Edit
Added
flatMapMaybe
andflatMapSingle
variants to bothFlowable
andObservable
.