Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation updates #4798

Merged
merged 2 commits into from
Nov 3, 2016
Merged

documentation updates #4798

merged 2 commits into from
Nov 3, 2016

Conversation

qwert2603
Copy link
Contributor

No description provided.

@akarnokd akarnokd added this to the 2.0 backlog milestone Nov 3, 2016
@akarnokd
Copy link
Member

akarnokd commented Nov 3, 2016

io.reactivex.JavadocWording > observableDocRefersToObservableTypes FAILED
java.lang.AssertionError: java.lang.RuntimeException: a/an typo Flowable
at io.reactivex.Observable (Observable.java:11740)
at org.junit.Assert.fail(Assert.java:88)
at io.reactivex.JavadocWording.observableDocRefersToObservableTypes(JavadocWording.java:418)
io.reactivex.TextualAorAn > checkFiles FAILED
java.lang.AssertionError: java.lang.RuntimeException: ' an Flowable'
at io.reactivex.Observable (Observable.java:11740)
at io.reactivex.TextualAorAn.checkFiles(TextualAorAn.java:82)

@@ -11737,7 +11737,7 @@ public final void subscribe(Observer<? super T> observer) {
}

/**
* Converts the current Observable into an Observable by applying the specified backpressure strategy.
* Converts the current Observable into an Flowable by applying the specified backpressure strategy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a Flowable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foolish mistake

@codecov-io
Copy link

codecov-io commented Nov 3, 2016

Current coverage is 95.78% (diff: 100%)

Merging #4798 into 2.x will decrease coverage by 0.04%

@@                2.x      #4798   diff @@
==========================================
  Files           570        570          
  Lines         36717      36717          
  Methods           0          0          
  Messages          0          0          
  Branches       5554       5554          
==========================================
- Hits          35187      35169    -18   
- Misses          624        633     +9   
- Partials        906        915     +9   

Powered by Codecov. Last update f2351e2...d26c614

@JakeWharton
Copy link
Contributor

Love that there's a linter for correct English!

On Thu, Nov 3, 2016, 7:47 AM Codecov notifications@github.com wrote:

Current coverage https://codecov.io/gh/ReactiveX/RxJava/pull/4798?src=pr
is 95.78% (diff: 100%)

Merging #4798 https://codecov.io/gh/ReactiveX/RxJava/pull/4798?src=pr
into 2.x https://codecov.io/gh/ReactiveX/RxJava/branch/2.x?src=pr will
decrease coverage by 0.04%

@@ 2.x #4798 diff @@

Files 570 570
Lines 36717 36717
Methods 0 0
Messages 0 0
Branches 5554 5554
==========================================- Hits 35187 35169 -18 - Misses 624 633 +9 - Partials 906 915 +9

Powered by Codecov https://codecov.io?src=pr. Last update
f2351e2...d26c614
https://codecov.io/gh/ReactiveX/RxJava/compare/f2351e22df729426a3cdbbbaeecf6ace18b94905...d26c614699ce83e3db6ae51a522e6b6835957402?src=pr


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#4798 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEXlCSbMEOKlKtqW8KC0OH7D58XH1ks5q6cnGgaJpZM4KoHWK
.

@akarnokd akarnokd merged commit 0107e3a into ReactiveX:2.x Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants