2.x: fix Observable.concatMapEager bad logic for immediate scalars #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
reviewed
Jan 11, 2017
| .concatMapEager(new Function<Integer, Flowable<Integer>>() { | ||
| @Override | ||
| public Flowable<Integer> apply(Integer i) throws Exception { | ||
| System.out.println("Processing " + i); |
There was a problem hiding this comment.
Just cluttering it up and can be removed?
vanniktech
reviewed
Jan 11, 2017
| .concatMapEager(new Function<Integer, ObservableSource<Integer>>() { | ||
| @Override | ||
| public ObservableSource<Integer> apply(Integer i) throws Exception { | ||
| System.out.println("Processing " + i); |
Current coverage is 95.65% (diff: 100%)@@ 2.x #4982 diff @@
==========================================
Files 592 592
Lines 37977 37968 -9
Methods 0 0
Messages 0 0
Branches 5754 5752 -2
==========================================
+ Hits 36287 36320 +33
+ Misses 720 700 -20
+ Partials 970 948 -22
|
JakeWharton
approved these changes
Jan 11, 2017
This was referenced Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator
Observable.concatMapEagerhad a bad optimization targeting scalar and callable sources and emitted their values immediately even if it wasn't that particular source's turn for it.The
Flowableis not affected, added unit tests for both.Reported in #4981.