Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: fix Flowable.flatMapMaybe/Single maxConcurrency not requesting more #5287

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

akarnokd
Copy link
Member

This PR fixes Flowable.flatMapMaybe and Flowable.flatMapSingle not replenishing from the upstream when they complete/error per inner source.

@akarnokd akarnokd added this to the 2.0 backlog milestone Apr 16, 2017
@codecov
Copy link

codecov bot commented Apr 16, 2017

Codecov Report

Merging #5287 into 2.x will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5287      +/-   ##
============================================
- Coverage     96.05%   96.03%   -0.03%     
- Complexity     5748     5755       +7     
============================================
  Files           628      628              
  Lines         41077    41085       +8     
  Branches       5699     5703       +4     
============================================
- Hits          39455    39454       -1     
- Misses          648      650       +2     
- Partials        974      981       +7
Impacted Files Coverage Δ Complexity Δ
...rnal/operators/flowable/FlowableFlatMapSingle.java 97.82% <100%> (+2.22%) 2 <0> (ø) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 96.13% <100%> (+2.1%) 2 <0> (ø) ⬇️
...a/io/reactivex/processors/SerializedProcessor.java 91.48% <0%> (-6.39%) 27% <0%> (-1%)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 87.61% <0%> (-4.87%) 61% <0%> (ø)
...ternal/operators/flowable/FlowableSampleTimed.java 91.17% <0%> (-4.42%) 3% <0%> (ø)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
...rnal/operators/completable/CompletableTimeout.java 94% <0%> (-4%) 2% <0%> (ø)
...vex/internal/operators/single/SingleTakeUntil.java 91.8% <0%> (-3.28%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 90.9% <0%> (-3.21%) 5% <0%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434d1f4...6430cb2. Read the comment docs.

@akarnokd akarnokd merged commit 2abeadb into ReactiveX:2.x Apr 17, 2017
@akarnokd akarnokd deleted the FixFlowableFlatMapMaybe branch April 17, 2017 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants