Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix typo in error message. #5354

Merged
merged 1 commit into from
May 18, 2017
Merged

2.x: Fix typo in error message. #5354

merged 1 commit into from
May 18, 2017

Conversation

ragunathjawahar
Copy link
Contributor

@ragunathjawahar ragunathjawahar commented May 18, 2017

When BaseTestConsumer receives fewer items than expected, the error shown has a typo. Replaced Fever with Fewer.

@akarnokd
Copy link
Member

You are supposed to replace the intro text with the description of your PR...

@ragunathjawahar
Copy link
Contributor Author

Done, thank you for the info.

@akarnokd akarnokd merged commit c799bc0 into ReactiveX:2.x May 18, 2017
@codecov
Copy link

codecov bot commented May 18, 2017

Codecov Report

Merging #5354 into 2.x will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #5354      +/-   ##
===========================================
- Coverage     96.2%   96.19%   -0.02%     
+ Complexity    5790     5782       -8     
===========================================
  Files          630      630              
  Lines        41162    41162              
  Branches      5721     5721              
===========================================
- Hits         39601    39596       -5     
- Misses         607      616       +9     
+ Partials       954      950       -4
Impacted Files Coverage Δ Complexity Δ
.../java/io/reactivex/observers/BaseTestConsumer.java 99.6% <100%> (ø) 108 <0> (ø) ⬇️
...in/java/io/reactivex/subjects/BehaviorSubject.java 85.93% <0%> (-5.73%) 56% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 60.28% <0%> (-4.26%) 32% <0%> (-3%)
...internal/operators/completable/CompletableAmb.java 94.91% <0%> (-3.39%) 10% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.2% <0%> (-3.39%) 2% <0%> (ø)
...activex/internal/operators/single/SingleCache.java 97.05% <0%> (-2.95%) 23% <0%> (-1%)
...rnal/operators/flowable/FlowableTakeLastTimed.java 96.29% <0%> (-2.78%) 2% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 61.53% <0%> (-2.57%) 12% <0%> (-1%)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-2.5%) 2% <0%> (ø)
...main/java/io/reactivex/subjects/SingleSubject.java 97.61% <0%> (-2.39%) 39% <0%> (-1%)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b8d58...8448c28. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants