Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: fix time bounded replaySubject getValue() inconsistency with getValues() on old items #5434

Merged
merged 4 commits into from
Jun 21, 2017

Conversation

nathankooij
Copy link
Contributor

See #5433.

@akarnokd akarnokd modified the milestones: 2.0 backlog, 2.2 Jun 21, 2017
@akarnokd akarnokd changed the title 2.x Time bounded replaySubject getValue() unexpected behavior 2.x: fix time bounded replaySubject getValue() inconsistency with getValues() on old items Jun 21, 2017
Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The build may need several restart as currently it either times out or gets killed by the container for some reason.

@codecov
Copy link

codecov bot commented Jun 21, 2017

Codecov Report

Merging #5434 into 2.x will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5434      +/-   ##
============================================
+ Coverage     96.02%   96.07%   +0.05%     
- Complexity     5787     5801      +14     
============================================
  Files           631      631              
  Lines         41291    41297       +6     
  Branches       5742     5744       +2     
============================================
+ Hits          39648    39678      +30     
+ Misses          650      634      -16     
+ Partials        993      985       -8
Impacted Files Coverage Δ Complexity Δ
.../java/io/reactivex/processors/ReplayProcessor.java 98.76% <100%> (ø) 49 <0> (ø) ⬇️
...main/java/io/reactivex/subjects/ReplaySubject.java 96.47% <100%> (+0.02%) 50 <0> (ø) ⬇️
...ternal/operators/flowable/FlowableSubscribeOn.java 91.52% <0%> (-6.78%) 2% <0%> (ø)
...vex/internal/operators/single/SingleTakeUntil.java 86.88% <0%> (-6.56%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 88.77% <0%> (-5.35%) 5% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 91.22% <0%> (-4.39%) 9% <0%> (-1%)
.../internal/operators/maybe/MaybeTakeUntilMaybe.java 93.87% <0%> (-4.09%) 2% <0%> (ø)
...ex/internal/operators/maybe/MaybeTimeoutMaybe.java 95.58% <0%> (-2.95%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.75% <0%> (-2.18%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 95.1% <0%> (-2.18%) 2% <0%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3172b...3eec629. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants