Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: upgrade Reactive-Streams dependency to 1.0.1 #5546

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Aug 9, 2017

This PR upgrades the dependency to Reactive-Streams 1.0.1 final, and

  • organizes the other dependency versions into nice variables,
  • allows the javadoc generator to link to the RS javadoc.

A couple of remarks on the other dependency versions:

  • JMH 1.16: last version that supports Java 6
  • TestNG 6.9.10: last version that doesn't break the RS TCK and works with the TestNG Eclipse plugin
  • Mockito 2.1.0: I guess upgrading within the minor version has little advertising value.
  • JUnit 4.12: Latest version everything supports as of now.

@akarnokd akarnokd added this to the 2.2 milestone Aug 9, 2017
@codecov
Copy link

codecov bot commented Aug 9, 2017

Codecov Report

Merging #5546 into 2.x will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #5546      +/-   ##
===========================================
+ Coverage     96.1%   96.18%   +0.08%     
  Complexity    5822     5822              
===========================================
  Files          631      631              
  Lines        41414    41414              
  Branches      5740     5740              
===========================================
+ Hits         39799    39833      +34     
+ Misses         656      627      -29     
+ Partials       959      954       -5
Impacted Files Coverage Δ Complexity Δ
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
.../internal/operators/flowable/FlowableInterval.java 94.44% <0%> (-2.78%) 3% <0%> (ø)
...ex/internal/operators/flowable/FlowableCreate.java 95.48% <0%> (-2.26%) 6% <0%> (ø)
...java/io/reactivex/processors/PublishProcessor.java 98.29% <0%> (-1.71%) 45% <0%> (-1%)
...internal/operators/completable/CompletableAmb.java 98.3% <0%> (-1.7%) 11% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
...reactivex/internal/queue/SpscLinkedArrayQueue.java 96.82% <0%> (-0.8%) 38% <0%> (-1%)
...operators/flowable/FlowableWithLatestFromMany.java 99.24% <0%> (-0.76%) 7% <0%> (ø)
...ternal/operators/observable/ObservableGroupBy.java 96.36% <0%> (-0.61%) 2% <0%> (ø)
...nternal/operators/observable/ObservableReplay.java 98.05% <0%> (-0.56%) 23% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61b229...5950c4c. Read the comment docs.

@akarnokd akarnokd merged commit 0d0c38c into ReactiveX:2.x Aug 10, 2017
@akarnokd akarnokd deleted the ReactiveStreams1_0_1_final branch August 10, 2017 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants