2.x: Improved XSubject JavaDocs #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #5802 +/- ##
============================================
- Coverage 96.23% 96.18% -0.06%
+ Complexity 5814 5807 -7
============================================
Files 634 634
Lines 41647 41647
Branches 5776 5776
============================================
- Hits 40081 40057 -24
- Misses 620 634 +14
- Partials 946 956 +10
Continue to review full report at Codecov.
|
artem-zinnatullin
approved these changes
Jan 9, 2018
| * given {@code Disposable} being disposed immediately. | ||
| * <p> | ||
| * Calling {@link #onNext(Object)}, {@link #onError(Throwable)} and {@link #onComplete()} | ||
| * is still required to be serialized (called from the same thread or called non-overlappingly from different threads |
There was a problem hiding this comment.
nit: After reading this multiple times I kinda want to remove "still" from the sentence
| * Example usage: | ||
| * <pre> {@code | ||
|
|
||
| ReplaySubject<Object> subject = new ReplaySubject<>(); |
vanniktech
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more detailed JavaDoc descriptions to the various
XSubjecttypes.Some of them are missing a marble diagram which will be created (or found) in a separate PR after this PR.
The
package-info.javahas been extended as well.