-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Add refCount with count & disconnect timeout #5986
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5986 +/- ##
============================================
+ Coverage 98.22% 98.24% +0.01%
- Complexity 6053 6062 +9
============================================
Files 656 656
Lines 44078 44094 +16
Branches 6118 6118
============================================
+ Hits 43297 43321 +24
+ Misses 235 231 -4
+ Partials 546 542 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
This PR exposes the additional
refCount
operation modes from #5975:Subscriber
s/Observer
s have subscribedSubscriber
/Observer
cancelled/disposed.In addition, the original
refCount
received extra JavaDocs details.