2.x: Add assertValueSetOnly and assertValueSequenceOnly to TestObserver + TestSubscriber #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
reviewed
May 17, 2018
| * Assert that the TestObserver/TestSubscriber received only the specified values in any order without terminating. | ||
| * @param values the values expected | ||
| * @return this; | ||
| * @since 2.1.14 |
There was a problem hiding this comment.
Please have these like this: 2.1.14 - experimental
akarnokd
reviewed
May 17, 2018
|
|
||
| try { | ||
| to.assertValueSetOnly(Collections.singleton(5)); | ||
| fail(); |
There was a problem hiding this comment.
fail throws AssertionError so this test always passes. Perhaps throw a RuntimeException or add a fail message and verify the catch wasn't that message. Also this is overlooked in many other test using fail and catch (AssertionError) so it would be great if this could be fixed as well.
akarnokd
reviewed
May 17, 2018
Codecov Report
@@ Coverage Diff @@
## 2.x #6010 +/- ##
============================================
- Coverage 98.28% 98.25% -0.04%
- Complexity 6074 6158 +84
============================================
Files 658 659 +1
Lines 44288 44522 +234
Branches 6145 6201 +56
============================================
+ Hits 43529 43743 +214
- Misses 228 233 +5
- Partials 531 546 +15
Continue to review full report at Codecov.
|
…er + TestSubscriber.
|
Addressed your feedback. |
akarnokd
reviewed
May 18, 2018
| * Assert that the TestObserver/TestSubscriber received only the specified values in any order without terminating. | ||
| * @param expected the collection of values expected in any order | ||
| * @return this; | ||
| * @since 2.1.14 |
akarnokd
reviewed
May 18, 2018
| * Assert that the TestObserver/TestSubscriber received only the specified values in the specified order without terminating. | ||
| * @param sequence the sequence of expected values in order | ||
| * @return this; | ||
| * @since 2.1.14 |
|
Whops. Forgot to commit that one, thanks. |
akarnokd
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically copies the behavior of
assertValuesOnlyto theassertValueSetandassertValueSequenceequivalent methods.Coped the tests exactly from
assertValuesOnlyand adjusted them with the new added methods.