Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Update the javadoc description of cast() #7606

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Oct 4, 2023

Reword the operator description to avoid some confusion how cast() works.

Resolves #7605

The related images had mistakes too and have been updated in the wiki section separately:

image]

image

image

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #7606 (555e196) into 3.x (e6f152d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.x    #7606      +/-   ##
============================================
- Coverage     99.60%   99.58%   -0.02%     
- Complexity     6801     6802       +1     
============================================
  Files           752      752              
  Lines         47707    47707              
  Branches       6401     6401              
============================================
- Hits          47520    47511       -9     
- Misses           85       89       +4     
- Partials        102      107       +5     
Files Coverage Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akarnokd akarnokd merged commit 4c59fa6 into 3.x Oct 4, 2023
7 checks passed
@akarnokd akarnokd deleted the CastJavadocFixes branch October 4, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3: The marble diagram for cast is incredibly misleading.
2 participants