Skip to content

Commit

Permalink
Fixes #195
Browse files Browse the repository at this point in the history
RxClient.shutdown() was shutting down the eventloop.

This caused the following scenario impossible to work:

1) Create some clients
2) Shutdown all of them
3) Create another client & try to use it.

In the above scenario, at stage 3, the eventloop is shutdown and hence can not be used by the newly created client.

Removing the eventloop shutdown. Since, the eventloop is always a daemon, shutting it down isn't really necessary.
We will think about graceful JVM shutdown scenarios and hence a need to provide a global shutdown on RxNetty later.
  • Loading branch information
Nitesh Kant committed Jul 31, 2014
1 parent 3ef1e47 commit dba704c
Showing 1 changed file with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,8 @@ public void shutdown() {
return;
}

try {
if (null != pool) {
pool.shutdown();
}
} finally {
clientBootstrap.group().shutdownGracefully();
if (null != pool) {
pool.shutdown();
}
}

Expand Down

0 comments on commit dba704c

Please sign in to comment.