Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RxClientImpl mutates the bootstrap per connection #117

Closed
NiteshKant opened this issue May 10, 2014 · 0 comments
Closed

RxClientImpl mutates the bootstrap per connection #117

NiteshKant opened this issue May 10, 2014 · 0 comments
Labels
bug
Milestone
0.3.5

Comments

@NiteshKant
Copy link
Member

RxClientImpl via ClientChannelFactoryImpl mutates the bootstrap object, updating the ChannelInitializer. This is wrong as the bootstrap is used across multiple connections and hence different initializers steps on each others steps.
This eventually ends up using the same ClientConnectionHandler across multiple connections and thus one subscriber of RxClient.submit() receives multiple onNext() calls.
In HTTP client this results in the same request being written multiple times on different connections.
@NiteshKant NiteshKant self-assigned this May 10, 2014
@NiteshKant NiteshKant added this to the 0.3.4 milestone May 10, 2014
@NiteshKant NiteshKant added the bug label May 10, 2014
NiteshKant pushed a commit to NiteshKant/RxNetty that referenced this issue May 17, 2014
Fix for issue ReactiveX#117 ReactiveX#113
d300f01
This was referenced May 17, 2014
Merged
Closed
Closed
Closed
NiteshKant added a commit that referenced this issue May 19, 2014
@NiteshKant
Merge pull request #120 from NiteshKant/master
42eafc4 
Fix for issue #117 #114 #113 #88
@NiteshKant NiteshKant removed their assignment Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.3.5
Development

No branches or pull requests
1 participant
@NiteshKant