Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default http header name for request ID in request context #134

Closed
allenxwang opened this issue Jun 2, 2014 · 2 comments
Closed

Provide default http header name for request ID in request context #134

allenxwang opened this issue Jun 2, 2014 · 2 comments
Milestone
0.3.6

Comments

@allenxwang
Copy link

Since RxNetty provides both server and client builders that build context aware objects, it will be convenient and less error prone if it can provide a default http request header name for request ID to be used on both client and server.

Ideally this default name should be configurable.
@NiteshKant NiteshKant added this to the 0.3.6 milestone Jun 2, 2014
@NiteshKant NiteshKant self-assigned this Jun 2, 2014
NiteshKant pushed a commit to NiteshKant/RxNetty that referenced this issue Jun 3, 2014
Fixes issue ReactiveX#134
bca6880 
Provided overloads for all method taking requestIdHeaderName to use the default header name.
The default header name can be set by calling RxContexts.useRequestIdContextKey()
@NiteshKant
Copy link
Member

@allenxwang let me know if the changes meet your needs.

@allenxwang
Copy link
Author

@NiteshKant looks good to me.

NiteshKant added a commit that referenced this issue Jun 3, 2014
@NiteshKant
Merge pull request #136 from NiteshKant/master
56588db 
Fixes issue #134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.6
Development

No branches or pull requests
2 participants
@NiteshKant @allenxwang