Fix for issue #117 #114 #113 #88

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/AbstractClientContextHandler.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 import io.netty.channel.ChannelHandlerContext;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/AbstractContextHandler.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 import io.netty.channel.ChannelDuplexHandler;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/AbstractServerContextHandler.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 import com.netflix.server.context.BiDirectional;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/ContextAttributeStorageHelper.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 import io.netty.channel.ChannelHandlerContext;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/ContextAwareEventLoopGroup.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 import io.netty.channel.Channel;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/ContextCapturer.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 import io.netty.util.Attribute;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/ContextPipelineConfigurators.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 import io.reactivex.netty.contexts.http.HttpClientContextConfigurator;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/RequestCorrelator.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 /**

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/RequestIdGenerator.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 import io.netty.channel.ChannelHandlerContext;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/RxContexts.java

@@ -18,7 +18,7 @@
 import io.netty.buffer.ByteBuf;
 import io.reactivex.netty.RxNetty;
 import io.reactivex.netty.client.RxClient;
-import io.reactivex.netty.contexts.http.HttpContextClientChannelAbstractFactory;
+import io.reactivex.netty.contexts.http.HttpContextClientChannelFactory;
 import io.reactivex.netty.contexts.http.HttpRequestIdProvider;
 import io.reactivex.netty.pipeline.PipelineConfigurator;
 import io.reactivex.netty.protocol.http.client.HttpClient;
@@ -70,9 +70,10 @@ public static <I, O> HttpServerBuilder<I, O> newHttpServerBuilder(int port, Requ
     public static <I, O> HttpClientBuilder<I, O> newHttpClientBuilder(String host, int port,
                                                                       RequestIdProvider provider,
                                                                       RequestCorrelator correlator) {
-        return RxNetty.<I, O>newHttpClientBuilder(host, port)
-                .pipelineConfigurator(ContextPipelineConfigurators.<I, O>httpClientConfigurator(provider, correlator))
-                .withClientChannelFactory(new HttpContextClientChannelAbstractFactory<I, O>(correlator));
+        HttpClientBuilder<I, O> builder = RxNetty.newHttpClientBuilder(host, port);
+        return builder.pipelineConfigurator(ContextPipelineConfigurators.<I, O>httpClientConfigurator(provider, correlator))
+                      .withChannelFactory(new HttpContextClientChannelFactory<I, O>(builder.getBootstrap(),
+                                                                                    correlator));
     }
 
     public static HttpServer<ByteBuf, ByteBuf> createHttpServer(int port, RequestHandler<ByteBuf, ByteBuf> requestHandler,

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/ThreadLocalRequestCorrelator.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts;
 
 import io.netty.channel.EventLoopGroup;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/http/HttpClientContextConfigurator.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package io.reactivex.netty.contexts.http;
 
 import io.netty.channel.ChannelPipeline;

rx-netty-contexts/src/main/java/io/reactivex/netty/contexts/http/HttpContextClientChannelFactory.java

@@ -0,0 +1,105 @@
+/*
+ * Copyright 2014 Netflix, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.reactivex.netty.contexts.http;
+
+import io.netty.bootstrap.Bootstrap;
+import io.netty.channel.ChannelFuture;
+import io.reactivex.netty.channel.ObservableConnection;
+import io.reactivex.netty.client.ClientChannelFactoryImpl;
+import io.reactivex.netty.client.ClientConnectionFactory;
+import io.reactivex.netty.client.RxClient;
+import io.reactivex.netty.contexts.ContextsContainer;
+import io.reactivex.netty.contexts.RequestCorrelator;
+import io.reactivex.netty.protocol.http.client.HttpClientRequest;
+import io.reactivex.netty.protocol.http.client.HttpClientResponse;
+import rx.Subscriber;
+
+import static io.reactivex.netty.contexts.AbstractClientContextHandler.NewContextEvent;
+
+/**
+ * @author Nitesh Kant
+ */
+public class HttpContextClientChannelFactory<I, O> extends
+        ClientChannelFactoryImpl<HttpClientResponse<O>, HttpClientRequest<I>> {
+
+    private final RequestCorrelator correlator;
+
+    public HttpContextClientChannelFactory(Bootstrap clientBootstrap, RequestCorrelator correlator) {
+        super(clientBootstrap);
+        this.correlator = correlator;
+    }
+
+    @Override
+    public ChannelFuture connect(
+            Subscriber<? super ObservableConnection<HttpClientResponse<O>, HttpClientRequest<I>>> subscriber,
+            RxClient.ServerInfo serverInfo,
+            ClientConnectionFactory<HttpClientResponse<O>, HttpClientRequest<I>,
+                    ? extends ObservableConnection<HttpClientResponse<O>, HttpClientRequest<I>>> connectionFactory) {
+        final ContextCapturingSubscriber capturingSubscriber = new ContextCapturingSubscriber(subscriber);
+        return super.connect(capturingSubscriber, serverInfo, connectionFactory);
+    }
+
+    @Override
+    public void onNewConnection(ObservableConnection<HttpClientResponse<O>, HttpClientRequest<I>> newConnection,
+                                Subscriber<? super ObservableConnection<HttpClientResponse<O>, HttpClientRequest<I>>> subscriber) {
+        /*
+         * This will either be called after a call to connect() or directly (from pool).
+         * If it is the former then the subscriber should already be a capturing sub. In case of latter, we should be
+         * called from the thread that has the relevant state & hence we capture the context now.
+         */
+        final Subscriber<? super ObservableConnection<HttpClientResponse<O>, HttpClientRequest<I>>> subToUse;
+        if (ContextCapturingSubscriber.class == subscriber.getClass()) {
+            subToUse = subscriber;
+        } else {
+            subToUse = new ContextCapturingSubscriber(subscriber);
+        }
+
+        super.onNewConnection(newConnection, subToUse);
+    }
+
+    private class ContextCapturingSubscriber extends Subscriber<ObservableConnection<HttpClientResponse<O>, HttpClientRequest<I>>> {
+
+        private final Subscriber<? super ObservableConnection<HttpClientResponse<O>, HttpClientRequest<I>>> original;
+        private final String requestId;
+        private final ContextsContainer container;
+
+        private ContextCapturingSubscriber(Subscriber<? super ObservableConnection<HttpClientResponse<O>, HttpClientRequest<I>>> original) {
+            super(original);
+            this.original = original;
+            requestId = correlator.getRequestIdForClientRequest();
+            container = correlator.getContextForClientRequest(requestId);
+        }
+
+        @Override
+        public void onCompleted() {
+            original.onCompleted();
+        }
+
+        @Override
+        public void onError(Throwable e) {
+            original.onError(e);
+        }
+
+        @Override
+        public void onNext(ObservableConnection<HttpClientResponse<O>, HttpClientRequest<I>> connection) {
+            if (null != requestId && null != container) {
+                connection.getChannelHandlerContext().pipeline()
+                          .fireUserEventTriggered(new NewContextEvent(requestId, container));
+            }
+            original.onNext(connection);
+        }
+    }
+}