Fixes issue #150 #175 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed all deprecated methods for PoolStats
|
RxNetty-pull-requests #105 FAILURE |
In benchmarks where metrics are not required, the system calls to get time (System.currentTimeMillis()) may introduce an unnecessary overhead. This change enables such benchmarks to disable these system calls to get metric durations. It is important to note that apart from these system time calls metric generation does not have an object allocation overhead. So, for any benchmarks the metrics infrastructure should not pose much overhead.
|
RxNetty-pull-requests #106 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#150: Removed all deprecated methods for PoolStats
#175: Provided a method to disable system time calls for metrics.