Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: monitors are not registered with servo #179

Merged
merged 3 commits into from
Jul 9, 2014

Conversation

NiteshKant
Copy link
Member

The code in RefCountingMonitor was:

        if (subscriptionCount.incrementAndGet() == 0) {
            ServoUtils.registerObject(monitorId, monitor);
        }

this means subscriptionCount has to be -1 for it to register. Fixed it to:

        if (subscriptionCount.getAndIncrement() == 0) {
            ServoUtils.registerObject(monitorId, monitor);
        }

@NiteshKant NiteshKant added this to the 0.3.9 milestone Jul 9, 2014
@NiteshKant NiteshKant added the bug label Jul 9, 2014
@NiteshKant NiteshKant self-assigned this Jul 9, 2014
@cloudbees-pull-request-builder

RxNetty-pull-requests #111 SUCCESS
This pull request looks good

NiteshKant added a commit that referenced this pull request Jul 9, 2014
Fixed: monitors are not registered with servo
@NiteshKant NiteshKant merged commit f4d4d5f into ReactiveX:master Jul 9, 2014
@cloudbees-pull-request-builder

RxNetty-pull-requests #112 FAILURE
Looks like there's a problem with this pull request

@NiteshKant NiteshKant removed their assignment Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants