Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator take does not unsubscribe from its source when it reaches the limit with sync source #1543

Closed
Igorbek opened this issue Mar 29, 2016 · 2 comments

Comments

@Igorbek
Copy link
Contributor

Igorbek commented Mar 29, 2016

RxJS version:
master branch.

Code to reproduce:

Observable.create(observer => {
      expect(observer.isUnsubscribed).toBe(false);
      observer.next(42);
      expect(observer.isUnsubscribed).toBe(true); // fails here
    }).take(1).subscribe();

Expected behavior:

Test should have passed.

Actual behavior:

Test has failed.

@Igorbek Igorbek changed the title Operator take does not unsubscribe from its source when it reaches the limit Operator take does not unsubscribe from its source when it reaches the limit' Mar 29, 2016
@Igorbek Igorbek changed the title Operator take does not unsubscribe from its source when it reaches the limit' Operator take does not unsubscribe from its source when it reaches the limit Mar 29, 2016
@benlesh benlesh changed the title Operator take does not unsubscribe from its source when it reaches the limit Operator take does not unsubscribe from its source when it reaches the limit with sync source Mar 29, 2016
@kwonoj
Copy link
Member

kwonoj commented Mar 29, 2016

Closed via #1544.

@kwonoj kwonoj closed this as completed Mar 29, 2016
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants