Migrate test cases into mocha test runner #1545
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,46 @@ | ||
| import {expect} from 'chai'; | ||
| import * as Rx from '../dist/cjs/Rx'; | ||
|
|
||
| declare const expectObservable; | ||
| const Notification = Rx.Notification; | ||
|
|
||
| /** @test {Notification} */ | ||
| describe('Notification', () => { | ||
| it('should exist', () => { | ||
| expect(Notification).exist; | ||
| expect(Notification).to.be.a('function'); | ||
|
There was a problem hiding this comment. Wow, I'm sorry you had to go through each of these assertions. Could have used something like https://github.com/crysalead-js/chai-jasmine. Did you try that? There was a problem hiding this comment. was aware but didn't tempted quite especially given repo is somewhat inactive state. Updating assertion actually wasn't that hard, just simple replace. |
||
| }); | ||
|
|
||
| describe('createNext', () => { | ||
| it('should return a Notification', () => { | ||
| const n = Notification.createNext('test'); | ||
| expect(n instanceof Notification).to.be.true; | ||
| expect(n.value).to.equal('test'); | ||
| expect(n.kind).to.equal('N'); | ||
| expect(n.exception).to.be.a('undefined'); | ||
| expect(n.hasValue).to.be.true; | ||
| }); | ||
| }); | ||
|
|
||
| describe('createError', () => { | ||
| it('should return a Notification', () => { | ||
| const n = Notification.createError('test'); | ||
| expect(n instanceof Notification).to.be.true; | ||
| expect(n.value).to.be.a('undefined'); | ||
| expect(n.kind).to.equal('E'); | ||
| expect(n.exception).to.equal('test'); | ||
| expect(n.hasValue).to.be.false; | ||
| }); | ||
| }); | ||
|
|
||
| describe('createComplete', () => { | ||
| it('should return a Notification', () => { | ||
| const n = Notification.createComplete(); | ||
| expect(n instanceof Notification).to.be.true; | ||
| expect(n.value).to.be.a('undefined'); | ||
| expect(n.kind).to.equal('C'); | ||
| expect(n.exception).to.be.a('undefined'); | ||
| expect(n.hasValue).to.be.false; | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -67,28 +68,28 @@ describe('Notification', () => { | |
| const first = Notification.createNext(value); | ||
| const second = Notification.createNext(value); | ||
|
|
||
| expect(first).not.to.equal(second); | ||
| }); | ||
|
|
||
| it('should create new error Notification', () => { | ||
| const first = Notification.createError(); | ||
| const second = Notification.createError(); | ||
|
|
||
| expect(first).not.to.equal(second); | ||
| }); | ||
|
|
||
| it('should return static next Notification reference without value', () => { | ||
| const first = Notification.createNext(undefined); | ||
| const second = Notification.createNext(undefined); | ||
|
|
||
| expect(first).to.equal(second); | ||
| }); | ||
|
|
||
| it('should return static complete Notification reference', () => { | ||
| const first = Notification.createComplete(); | ||
| const second = Notification.createComplete(); | ||
|
|
||
| expect(first).to.equal(second); | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -104,7 +105,7 @@ describe('Notification', () => { | |
| throw 'should not be called'; | ||
| }); | ||
|
|
||
| expect(invoked).to.be.true; | ||
| }); | ||
|
|
||
| it('should invoke on error', () => { | ||
|
|
@@ -118,7 +119,7 @@ describe('Notification', () => { | |
| throw 'should not be called'; | ||
| }); | ||
|
|
||
| expect(invoked).to.be.true; | ||
| }); | ||
|
|
||
| it('should invoke on complete', () => { | ||
|
|
@@ -132,7 +133,7 @@ describe('Notification', () => { | |
| invoked = true; | ||
| }); | ||
|
|
||
| expect(invoked).to.be.true; | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -142,7 +143,7 @@ describe('Notification', () => { | |
| let observed = false; | ||
| const n = Notification.createNext(value); | ||
| const observer = Rx.Subscriber.create((x: string) => { | ||
| expect(x).to.equal(value); | ||
| observed = true; | ||
| }, (err: any) => { | ||
| throw 'should not be called'; | ||
|
|
@@ -151,7 +152,7 @@ describe('Notification', () => { | |
| }); | ||
|
|
||
| n.accept(observer); | ||
| expect(observed).to.be.true; | ||
| }); | ||
|
|
||
| it('should accept observer for error Notification', () => { | ||
|
|
@@ -166,7 +167,7 @@ describe('Notification', () => { | |
| }); | ||
|
|
||
| n.accept(observer); | ||
| expect(observed).to.be.true; | ||
| }); | ||
|
|
||
| it('should accept observer for complete Notification', () => { | ||
|
|
@@ -181,7 +182,7 @@ describe('Notification', () => { | |
| }); | ||
|
|
||
| n.accept(observer); | ||
| expect(observed).to.be.true; | ||
| }); | ||
|
|
||
| it('should accept function for next Notification', () => { | ||
|
|
@@ -190,14 +191,14 @@ describe('Notification', () => { | |
| const n = Notification.createNext(value); | ||
|
|
||
| n.accept((x: string) => { | ||
| expect(x).to.equal(value); | ||
| observed = true; | ||
| }, (err: any) => { | ||
| throw 'should not be called'; | ||
| }, () => { | ||
| throw 'should not be called'; | ||
| }); | ||
| expect(observed).to.be.true; | ||
| }); | ||
|
|
||
| it('should accept function for error Notification', () => { | ||
|
|
@@ -208,12 +209,12 @@ describe('Notification', () => { | |
| n.accept((x: any) => { | ||
| throw 'should not be called'; | ||
| }, (err: any) => { | ||
| expect(err).to.equal(error); | ||
| observed = true; | ||
| }, () => { | ||
| throw 'should not be called'; | ||
| }); | ||
| expect(observed).to.be.true; | ||
| }); | ||
|
|
||
| it('should accept function for complete Notification', () => { | ||
|
|
@@ -227,7 +228,7 @@ describe('Notification', () => { | |
| }, () => { | ||
| observed = true; | ||
| }); | ||
| expect(observed).to.be.true; | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -237,7 +238,7 @@ describe('Notification', () => { | |
| let observed = false; | ||
| const n = Notification.createNext(value); | ||
| const observer = Rx.Subscriber.create((x: string) => { | ||
| expect(x).to.equal(value); | ||
| observed = true; | ||
| }, (err: any) => { | ||
| throw 'should not be called'; | ||
|
|
@@ -246,7 +247,7 @@ describe('Notification', () => { | |
| }); | ||
|
|
||
| n.observe(observer); | ||
| expect(observed).to.be.true; | ||
| }); | ||
|
|
||
| it('should observe for error Notification', () => { | ||
|
|
@@ -261,7 +262,7 @@ describe('Notification', () => { | |
| }); | ||
|
|
||
| n.observe(observer); | ||
| expect(observed).to.be.true; | ||
| }); | ||
|
|
||
| it('should observe for complete Notification', () => { | ||
|
|
@@ -276,7 +277,7 @@ describe('Notification', () => { | |
| }); | ||
|
|
||
| n.observe(observer); | ||
| expect(observed).to.be.true; | ||
| }); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to replace this with
karma-mocha?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't include browser test configuration update as noted. May need track it separately.