Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(audit): fix crashes in case of the duration Observable completes #2743

Closed
wants to merge 2 commits into from
Closed

fix(audit): fix crashes in case of the duration Observable completes #2743

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc00efd
fix(audit): fix crashes in case of the duration Observable completes
asnov Jul 12, 2017
8ab485c
test(audit): respond to feedback
asnov Jul 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions spec/operators/audit-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,18 @@ describe('Observable.prototype.audit', () => {
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should mirror source if durations are Observable.of()', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather name it for synchronous observable instead of specifically say of operator (this could happen for any synchronous observable).

const e1 = hot('abcdefabcdefabcdefabcdefa|');
const e1subs = '^ !';
const e2 = Rx.Observable.of('one single value');
const expected = 'abcdefabcdefabcdefabcdefa|';

const result = e1.audit(() => e2);

expectObservable(result).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should emit no values if duration is a never', () => {
const e1 = hot('----abcdefabcdefabcdefabcdefa|');
const e1subs = '^ !';
Expand Down
2 changes: 1 addition & 1 deletion src/operator/audit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class AuditSubscriber<T, R> extends OuterSubscriber<T, R> {
this.destination.error(errorObject.e);
} else {
const innerSubscription = subscribeToResult(this, duration);
if (innerSubscription.closed) {
if (!innerSubscription || innerSubscription.closed) {
this.clearThrottle();
} else {
this.add(this.throttled = innerSubscription);
Expand Down