-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update nx to latest, simplify config #7428
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ | |
} | ||
}, | ||
"release": { | ||
"projects": ["rxjs"], | ||
"releaseTagPattern": "{version}", | ||
"changelog": { | ||
"git": { | ||
|
@@ -25,15 +26,10 @@ | |
}, | ||
"projectChangelogs": true | ||
}, | ||
"groups": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A single group is no longer required, we can use the projects shorthand and not need the nested structure (and not need to give it a name) |
||
"npm": { | ||
"projects": ["rxjs"], | ||
"version": { | ||
"generatorOptions": { | ||
"currentVersionResolver": "git-tag", | ||
"specifierSource": "conventional-commits" | ||
} | ||
} | ||
"version": { | ||
"generatorOptions": { | ||
"currentVersionResolver": "git-tag", | ||
"specifierSource": "conventional-commits" | ||
} | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,8 +56,6 @@ const yargs = require('nx/node_modules/yargs'); | |
|
||
const { workspaceVersion, projectsVersionData } = await releaseVersion({ | ||
specifier: options.version, | ||
// stage package.json updates to be committed later by the changelog command | ||
stageChanges: true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is essentially always needed for the common case, so it's true by default now |
||
dryRun: options.dryRun, | ||
verbose: options.verbose, | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committing and tagging by default after/as part of the changelog generation step just makes a lot sense based on more and more real world usage, so we updated the latest nx to make it so and can streamline the config. As before the logs, in both dry-run and non dry-run, explain when and what git commands are/would be running