Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for thisArgs issue #992

Merged
merged 2 commits into from
Dec 8, 2015
Merged

Updates for thisArgs issue #992

merged 2 commits into from
Dec 8, 2015

Commits on Dec 8, 2015

  1. refactor(skipWhile): remove thisArg argument 

    - removes thisArg and tests around that from skipWhile
- removes extra thisArg on interface defs for first and last as well

BREAKING CHANGE: skipWhile no longer accepts a thisArg argument
related #878
    @benlesh
    benlesh committed Dec 8, 2015
    Configuration menu
    Copy the full SHA
    d8f7297 View commit details
    Browse the repository at this point in the history

  2. feat(forEach): add thisArg 

    - adds thisArg as second argument to have symmetry with native Array forEach
- eliminates closures by leveraging named function instances
- adds test for thisArg passing
- updates tests to accommodate thisArg

BREAKING CHANGE: Observable.prototype.forEach argument order changed to accommodate thisArg. Optional PromiseCtor argument moved to third arg from second
closes #878
    @benlesh
    benlesh committed Dec 8, 2015
    Configuration menu
    Copy the full SHA
    14ffce6 View commit details
    Browse the repository at this point in the history