Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Update to SoundSwallower 0.6.0 #42

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Update to SoundSwallower 0.6.0 #42

merged 4 commits into from
Jan 27, 2023

Conversation

dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Jan 26, 2023

Allows us to reduce, but sadly not eliminate, custom webpack configuration, because webpack's default behaviour is fine but Angular overrides it internally with something that doesn't work at all: angular/angular-cli#24617

Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works on my machine. My only question is whether you're planning to upgrade to ss 0.6.1 soon too, since you've just created that tag, but it doesn't matter, we can merge this and merge a 0.6.1 update later too.

package-lock.json Show resolved Hide resolved
@dhdaines
Copy link
Contributor Author

Ah, actually it would probably be good to go to soundswallower 0.6.1, as there is a small problem in 0.6.0 (which doesn't seem to necessarily cause a failure all the time, not sure why): emscripten-core/emscripten#18610

@dhdaines
Copy link
Contributor Author

So also - there are two possible solutions - in the long run we may want to explicitly include the WASM in assets and disable entirely import.meta.url parsing by webpack, since this matches what Angular+esbuild will do (even though I consider it to be totally wrong because WASM is not an "asset" but part of the code), but that runs into an Angular bug which breaks testing, so this is the best way to go for the moment.

@dhdaines dhdaines merged commit b5f425d into main Jan 27, 2023
@dhdaines dhdaines deleted the dev.soundswallower060 branch January 27, 2023 15:54
@joanise
Copy link
Member

joanise commented Jan 27, 2023

I'm going to trust your judgement on all that. I saw a long conversation between you and Aidan about that, but I have not taken the time to understand it yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants