Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create release workflow not copying Android libraries #76

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

madmiraal
Copy link
Contributor

#73 introduced a bug into the nightly create-release build workflow: The Rebel Engine libraries are not being copied into the templates. This PR ensures the libraries are correctly copied before creating the Android templates.

In addition, it correctly cleans the Android custom build template by deleting the Rebel Engine Android archive libraries when running the cleanAndroidTemplates Gradle task.

@madmiraal madmiraal added PR Type: Bug Fix Your current game should now work as expected. Priority: Urgent To be included in the next patch release. labels Jun 13, 2024
@DanielaOrtner DanielaOrtner self-requested a review June 13, 2024 17:38
Copy link
Contributor

@DanielaOrtner DanielaOrtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly!

@DanielaOrtner DanielaOrtner merged commit 23aad9a into RebelToolbox:main Jun 13, 2024
15 checks passed
@madmiraal madmiraal deleted the fix-android-release branch June 13, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Type: Bug Fix Your current game should now work as expected. Priority: Urgent To be included in the next patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants