Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create release workflow not renaming android library #87

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

madmiraal
Copy link
Contributor

When creating the Android templates during the release creation, we are not renaming the Rebel Engine library files to librebel_android.so; so the Android app cannot find it.
This PR ensures that, when creating a release, the Rebel Engine library files are renamed to librebel_android.so.

@madmiraal madmiraal added PR Type: Bug Fix Your current game should now work as expected. Priority: Urgent To be included in the next patch release. labels Jul 12, 2024
@DanielaOrtner DanielaOrtner self-requested a review July 12, 2024 18:39
Copy link
Contributor

@DanielaOrtner DanielaOrtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for getting this done before the weekend :)

@DanielaOrtner DanielaOrtner merged commit 1211d5d into RebelToolbox:main Jul 12, 2024
15 checks passed
@madmiraal madmiraal deleted the fix-create-release branch July 13, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Type: Bug Fix Your current game should now work as expected. Priority: Urgent To be included in the next patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants